Update apitest docs for bitcoin-core v0.21 compat #5421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implemenation is already present in CoreWalletsService
- Finished API server's verify bsq payment impl. - Added verifybsqsenttoaddress method to CLI. - Added verifybsqsenttoaddress-help.txt to server. - Fixed client getoffers, getmyoffers to work with BSQ offers.
- Added CreateBSQOffersTest, TakeBuyBSQOfferTest, TakeSellBSQOfferTest. The first tests bsq offer creation, the second & third test bsq trade protocol, and includes bsq payment verification checks. - Made test dispute agent registration a test harness opt. It was a test case option, now it happens by default. - Moved some global test constants into ApiTestConfig. Adjusted affected test cases.
- Append minFeeServiceRate to TxFeeRateInfo proto. - Display min rate in CLI console. - Fix broken test due to changing min fee rate.
The test harness is compatible with bitcoin-core 0.19, 0.20, 0.21. Also removed some unnecessary comments about registering dispute agents in the test harness because it now happens by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test harness is compatible with bitcoin-core 0.19, 0.20, 0.21.
Also removed some unnecessary comments about registering dispute agents in the test harness because it now happens by default.
PR #5420 needs to be reviewed/merged before this one.