-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete API support for BSQ/BTC trade pair #5412
Merged
sqrrm
merged 5 commits into
bisq-network:master
from
ghubstan:complete-api-bsqbtc-trade-support
Apr 20, 2021
Merged
Complete API support for BSQ/BTC trade pair #5412
sqrrm
merged 5 commits into
bisq-network:master
from
ghubstan:complete-api-bsqbtc-trade-support
Apr 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implemenation is already present in CoreWalletsService
- Finished API server's verify bsq payment impl. - Added verifybsqsenttoaddress method to CLI. - Added verifybsqsenttoaddress-help.txt to server. - Fixed client getoffers, getmyoffers to work with BSQ offers.
- Added CreateBSQOffersTest, TakeBuyBSQOfferTest, TakeSellBSQOfferTest. The first tests bsq offer creation, the second & third test bsq trade protocol, and includes bsq payment verification checks. - Made test dispute agent registration a test harness opt. It was a test case option, now it happens by default. - Moved some global test constants into ApiTestConfig. Adjusted affected test cases.
ghubstan
changed the title
Complete API support to BSQ/BTC trade pair
Complete API support for BSQ/BTC trade pair
Apr 15, 2021
Here is an example BSQ trade using the CLI. Alice getunusedbsqaddress
Alice createcryptopaymentacct
Bob getunusedbsqaddress
Bob createcryptopaymentacct
Alice createoffer to Sell BSQ
Alice getmyoffer
Bob getoffers
Bob takeoffer
Bob gettrade
Alice gettrade
Bob sendbsq (payment)
Bob confirmpaymentstarted
Alice check trade 'BSQ Sent' status
Alice verify 2K BSQ sent to payment acct receiving address Bn3PCQgRwhkrGnaMp1RYwt9tFwL51YELqne
Alice sends confirmpaymentreceived message
Bob closes trade with keepfunds (sets trade state to CLOSED)
Alice closes trade with keepfunds (sets trade state to CLOSED)
Alice getbalance
Bob getbalance
|
sqrrm
approved these changes
Apr 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished API server's verify bsq payment impl.
Added
verifybsqsenttoaddress
method to CLI.Added
verifybsqsenttoaddress-help.txt
to server.Fixed client
getoffers
,getmyoffers
to work with BSQ offers.Configure call rate meter for
CreateCryptoCurrencyPaymentAccount
.Added
CreateBSQOffersTest
,TakeBuyBSQOfferTest
,TakeSellBSQOfferTest
.The first tests bsq offer creation, the second & third test bsq trade protocol, and includes bsq payment verification checks.
Made test dispute agent registration a test harness opt.
It was a test case opt, now it happens by default.
Moved some global test constants into
ApiTestConfig
.Adjusted affected test cases.