Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak wording for takeOffer.fundsBox.isOfferAvailable #5402

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

maxim-belkin
Copy link
Contributor

Minor wording tweak. This message is automatically displayed before the buyer can take the offer, so it makes sense to say {that Bisq is} checking if the offer is still available.

@boring-cyborg
Copy link

boring-cyborg bot commented Apr 9, 2021

Thanks for opening this pull request!

Please check out our contributor checklist and check if Travis or Codacy found any issues with your PR. Also make sure your commits are signed, and that you applied Bisq's code style and formatting.

A maintainer will add an is:priority label to your PR if it is up for compensation. Please see our Bisq Q1 2020 Update post for more details.

@ripcurlx
Copy link
Contributor

@m52go ☝️ Could you please review this one? Thanks!

@m52go
Copy link
Contributor

m52go commented Apr 12, 2021

Makes sense 👍

utACK

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 92a9cb6 into bisq-network:master Apr 12, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 12, 2021

Awesome work, congrats on your first merged pull request!

@ripcurlx ripcurlx added this to the v1.6.3 milestone Apr 12, 2021
@maxim-belkin maxim-belkin deleted the wording-tweak branch April 12, 2021 14:30
@maxim-belkin
Copy link
Contributor Author

Thank you both for approving and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants