Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ClassCastError in Portfolio History Summary Popup #5363

Merged
merged 1 commit into from Mar 28, 2021
Merged

Fix ClassCastError in Portfolio History Summary Popup #5363

merged 1 commit into from Mar 28, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 26, 2021

Fix another ClassCastError.

There is a Show Summary window which also has the same issue that PR #5358 fixed in Portfolio History.

image

image

Mar-26 15:49:37.872 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: Uncaught Exception from thread JavaFX Application Thread 
Mar-26 15:49:37.872 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: throwableMessage= bisq.core.offer.OpenOffer cannot be cast to bisq.core.trade.Trade 
Mar-26 15:49:37.872 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: throwableClass= class java.lang.ClassCastException 
Mar-26 15:49:37.872 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: Stack trace:
java.lang.ClassCastException: bisq.core.offer.OpenOffer cannot be cast to bisq.core.trade.Trade
    at bisq.desktop.main.portfolio.closedtrades.ClosedTradesDataModel.lambda$getTotalTxFee$7(ClosedTradesDataModel.java:166)

@ripcurlx ripcurlx added this to the v1.6.1 milestone Mar 27, 2021
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 58d93f6 into bisq-network:master Mar 28, 2021
@ghost ghost mentioned this pull request Apr 2, 2021
@ghost ghost deleted the fix_ClassCastException2 branch May 29, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant