Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review changes for Disputes GUI #5349

Merged
merged 1 commit into from Mar 24, 2021
Merged

Review changes for Disputes GUI #5349

merged 1 commit into from Mar 24, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 24, 2021

  • highlight trade period end using an appropriate CSS alert style
  • system messages to show in chat unread message count

#5160 (comment)

Better would be e.g. to create a new class .alert without underline and hand, so it doesn't look like a link.

Done.

And one more thing I missed in the other PR and feels a little bit weird for the user. If a dispute is closed you get the notification popup. When you click on it, it opens the support section and the issue is selected. But it is greyed out and users might not know what to do. Maybe it is better to open in this case automatically the same action as a double click would trigger. WDYT?

I tried this and did not like it. There are already too many things that pop up, and having the first closed dispute pop open its chat view when entering support is very counter-intuative. NACK

Also it would be good to show a (1) badge over the chat icon for the system message, so people are looking into it. In the past the chat was open by default in-line. So at least a notification would be good.

Done.

highlight trade period end using an appropriate CSS alert style
system messages to show in chat unread message count
@ripcurlx ripcurlx added this to the v1.6.0 milestone Mar 24, 2021
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - Probably having the badge icon now also after a dispute is closed is enough indication that users actually click on the chat icon.

@ripcurlx ripcurlx merged commit b0a5a94 into bisq-network:master Mar 24, 2021
@BtcContributor
Copy link
Contributor

BtcContributor commented Mar 24, 2021

Tested ACK

As an improvement I would suggest to highlight the chat icon and badge when there are new messages to be read but the dispute is already closed.

bisq_chat

Edit:
See latest commit aea043e.

@ghost ghost mentioned this pull request Apr 2, 2021
@ghost ghost deleted the mediation_follow_up_issues branch May 29, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants