-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Route bitcoinj over jtoryproxy #534
Closed
dan-da
wants to merge
18
commits into
bisq-network:master
from
dan-da:route_bitcoinj_over_jtoryproxy
Closed
Route bitcoinj over jtoryproxy #534
dan-da
wants to merge
18
commits into
bisq-network:master
from
dan-da:route_bitcoinj_over_jtoryproxy
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d only for useTor==true case
+ Enable/Disable use of internal Tor proxy based on user pref. + parse and make use of --btcSeedNodes arg. + code in place for user to specify other socks5 proxy, eg i2p, ssh. it just needs GUI or CLI prefs added.
oops, I made this against master instead of Development. closing and will make a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is in response to #488. At this point, the code is generally working as intended but needs review by others.
Summary of Changes
Testing
I have run the code with the following permutations:
In all cases, the wallet service was able to get connected and function seemingly normally.
I have NOT yet been able to verify that bitcoinj is not somehow leaking connections outside Tor, via DNS or otherwise. If anyone knows a good tool for logging all outbound connections made by a process during its lifetime on linux, please let me know. wireshark and tcpdump are possibilities, but tcpdump is snapshot oriented and wireshark doesn't know anything about PID.
Suggestions for verification methodology appreciated. We should make sure it is not leaking before making a release.
Notes
Future Improvement
Bounty
@ManfredKarrer At such time as you think this code is worthy of the bounty, you can make payment to the address I've sent you privately. Here's my public key fingerprint to prove I am the same person.