Disambiguate payment acct json form's "country" field #5330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it clear the user needs to enter a two letter country code in json form's "country" field, not a country name. The json form's field name was not changed to "countryCode" in this change for the following reason: The API's payment account forms are dynamically generated using reflection, and PaymentAccount class hierarchy @Setter methods determine which form fields are included or excluded. Reflection and @Setter methods are also used when reading completed json forms, to set the field values on a new PaymentAccount instance before it is persisted. CountryBasedPaymentAccount subclasses have a country field and a @Setter, not a countryCode field, hence this shortcut to informing the user the country field value is a country-code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it clear the user needs to enter a two letter country code in the api's payment account json form's
countryfield, not a country name. A blank payment account json form now has acountrydefault value =your two letter country code.The json form's field name was not changed to countryCode for the following reason:
The API's payment account forms are dynamically generated using reflection, and
PaymentAccountclass hierarchy@Settermethods determine which form fields are included or excluded. Reflection and@Settermethods are also used when reading completed json forms, to set the field values on a new PaymentAccount instance before it is persisted.CountryBasedPaymentAccountsubclasses likeF2FAccounthave acountryfield and a@Setter, not a countryCode field, hence this shortcut to informing the user the country field value is a country-code.