-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower min deposit to 0.001 BTC #5326
Conversation
Lower min refund to half of min deposit as it doesn't make sense to have a higher min refund than the min deposit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK - I'll test it in-depth during backwards comp. release tests.
Mediators always have to leave 0.003BTC for one of the parties. Could you test that it won't be an issue? |
Has a scale been considered before? For example, if a constant price in fiat of $31.25 is desired then: USD-----------------------------%BTC What if there were some sort of scale used to determine minimum security deposit based on bitcoin price in USD (for this example) rather than again make a fixed minimum security deposit like before (i.g., 0.006)? If price goes up or down significantly, then another change will be needed if a static minimum amount is set with no scale, as proposed here with the 0.001 BTC. If security deposits were based on a scale, it would adjust as price changes. If the value of the security deposit changes significantly then the trade can be placed on hold until more collateral is deposited (price goes up) or returned (price goes down). |
Also, what is to happen to the smaller trades on Bisq with the current security deposit of 0.006 BTC? For example, there is currently a trade up for 0.001 BTC but requires a security deposit of 0.006 BTC (600%!) Perhaps the difference should be returned, allowed to edit, or moved to make another trade? |
I'll test it and post my results here. |
This has been adapted as well. |
Lower min refund to half of min deposit as it doesn't make sense to have
a higher min refund than the min deposit.
Lower min deposit to 0.001 BTC to be more reasonable in fiat terms. Would be good to change to use a fiat feed to determine this value in the future.
Implements suggestion in bisq-network/proposals#323