Lower tolerated small amount #5318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split tolerated amount for placing offers with unsigned accounts and tolerated amount for taking offers.
ripcurlx
approved these changes
Mar 17, 2021
|
@ripcurlx The backwards compatibility is the main issue and def good that you test it. |
|
Hi @sqrrm I think 0.0025 BTC is too low: bisq-network/proposals#322 (comment) Is this commit putting in place the code to choose a selected amount or putting in place the 0.0025 BTC limit for new offers? |
|
@pazza83 This changes the max buy amount for unsigned accounts to 0.0025 BTC. |
|
@sqrrm is the signing requirement to get signed still 0.0025 BTC? |
|
This change done in this haphazard and non-democratic way will most likely be the final nail in the coffin of Bisq. Fortunately there are privacy-protecting alternatives these days. The Bisq "team" has zero understanding of economics and probabilities. So long and thanks for all the fish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split tolerated amount for placing offers with unsigned accounts
and tolerated amount for taking offers.
Implements suggestion in bisq-network/proposals#322
Split the small amount check between own side and peer side. Lower size that can be created but allows for taking already created buy offers with the old higher amount. The peer side check can later be lowered once the outstanding higher amount offers have been taken.