Fix singleton CoreContext usage #5292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After GrpcServer builds a gRPC server instance, it calls injected CoreContext#setApiUser(true). The same, singleton CoreContext object is injected into CoreService constructors, which use the coreContext# isApiUser value (set true by the server builder) to set their own class level boolean isApiUser fields. When CoreContext was added, I was fooled by the correct behavior I saw while stepping through the server debugger. But now I see that the correct boolean value in CoreContext is only available after CoreService constructors have finished instantiating themselves - - not in time. In this change, the CoreContext becomes a class level final field in CoreServices, and the correct coreContex.isApiUser value is available in the CoreService methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After
GrpcServerbuilds a gRPC server instance, it calls injectedCoreContext#setApiUser(true). The same, singletonCoreContextinstance is injected into CoreService constructors, which use thecoreContext#isApiUservalue (set true by the server builder) to set their own class level booleanisApiUserfields.When
CoreContextwas added, I was fooled by the correct behavior I saw while stepping through the server debugger. But now I see that the correct boolean value inCoreContextis only available after CoreService constructors have finished instantiating themselves -- not in time.In this change, the
isApiUserfield is removed from CoreServices,CoreContext coreContextbecomes a class level final field in CoreServices, and the correctcoreContex.isApiUservalue is available in the CoreService methods.This PR is the first in a new API PR chain.