Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase min withdrawal tx fee to 15 sats/vB #5224

Merged
merged 1 commit into from Feb 24, 2021
Merged

Increase min withdrawal tx fee to 15 sats/vB #5224

merged 1 commit into from Feb 24, 2021

Conversation

ghost
Copy link

@ghost ghost commented Feb 23, 2021

Due to mempool congestion, increased from 2 to 15

Requested by @wiz.

@wiz
Copy link
Contributor

wiz commented Feb 24, 2021

Thanks for this emergency fix to prevent wallet corruption. To be clear, we need a proper solution that uses the dynamic mempoolminfee, but that will require the following steps:

  • mempool.space/api needs to add the mempoolminfee value to the current fee estimation endpoint
  • bisq pricenodes need to store and serve the mempoolminfee value on its /getAllMarketInfo endpoint
  • bisq nodes need to dynamically adjust the value you're changing in this PR to mempoolminfee

@ripcurlx ripcurlx added this to the v1.5.7 milestone Feb 24, 2021
ripcurlx
ripcurlx approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - I'll cherry-pick it into v1.5.7

@ripcurlx ripcurlx merged commit f4d6986 into bisq-network:master Feb 24, 2021
@ghubstan ghubstan mentioned this pull request Feb 25, 2021
Merged
@ghost ghost mentioned this pull request Feb 28, 2021
Closed
@rafaelpac rafaelpac mentioned this pull request May 10, 2021
Merged
@ghost
Copy link
Author

ghost commented May 10, 2021

Note for people in the future: this was subsequently replaced by #5235

@ghost ghost deleted the increase_withdrawal_fee branch May 29, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.7
Development

Successfully merging this pull request may close these issues.
2 participants
@wiz @ripcurlx