Improve chat functionality of mediation/arbitration #5207

ghost · 2021-02-19T02:45:31Z

Show badge with number of unread chat messages on each ticket
Use icons for chat, info and process ticket functions
Select a row by clicking on it, no clunky select button needed.
Show chat messages in a movable/sizable popup window.
More space for ticket list.
@leo816 request : indicate if the trade period is over
@leo816 request : indicate the XMR tx proof
Indicate more clearly the sender of each chat message: the author of the messages is not clear in the mediation chat #3412
@ripcurlx request for Support badge count: Improve chat functionality of mediation/arbitration #5207 (comment)
@pazza83 Allow trader to close own mediation ticket if the trade is paid out (because in odd cases they do not get closed on the trader's side).

Fixes #5097
Fixes #3412

Agent view:

Client view:

Light mode:

@leo816
Indicate trade end period
Indicate XMR tx proof (when applicable)

@pazza83
Allow trader to close ticket if paid out

Indicate more clearly the sender (trader side):

Indicate more clearly the sender (agent side):

Conza88 · 2021-02-19T03:32:10Z

Too late to incorporate #5044 ? hah

ripcurlx · 2021-02-19T09:55:46Z

@jmacxx Great that you picked this up!

IMO we should only have the info icon in front and move the other action icons (process and chat) to the end. It just feels weird for me having this action icons in the front (yes, I know we had the CTA buttons there as well in the past). What do you think?

Also it would be great if you could adapt the badge number on the support button so it doesn't reflect the number of open support cases, but rather if there is an action that needs to be done. e.g. if there are new support cases add a new badge to the info icon (add the number of new support cases to the support button) and if it was selected once decrease the badge number and remove the new badge. If there are new chat message for a support case add (+1) to the support button badge and decrease it (-1) if the chat messages were viewed. If a support case was closed add +1 and decrease it if the final message by the mediator/arbitrator was viewed and so on. Do you know what I mean?

I think doing like that prevents that people are ignoring the badge icon as it is always there no matter if there is an action to do or not.

Show badge with number of unread chat messages on each ticket Use icons for chat, info and process ticket functions Select a row by clicking on it, no clunky select button needed. Show chat messages in a movable popup window. More space for ticket list. Implement requested feature additions: Indicate if the trade period is over Indicate more clearly the sender of each chat message Support badge count Indicate the XMR tx proof (when applicable) Allow trader to close own mediation ticket if the trade is paid out Fixes: null check for cases when extraData null/not applicable when upgrading closed disputes, clear chat unread count

ghost · 2021-03-04T01:12:22Z

Ready for review!

Dispute object now contains a State field to represent whether it is new, open, reopened, or closed => necessary for the count on the Support badge and displaying a "New" badge on table rows.

ripcurlx · 2021-03-11T16:00:00Z

@jmacxx Is there a reason why you chose orange for the new badge?

ghost · 2021-03-11T17:41:04Z

@jmacxx Is there a reason why you chose orange for the new badge?

You're right, it should be red. Fix pushed.

Conza88 · 2021-03-14T23:58:35Z

Awesome work

ripcurlx

NACK - Some naming suggestions and comments I would leave out of this PR.

Also I tested the functionality and found following UX issue:

When a new mediation case is opened it looks like that to the user:

It is not immediately clear to me what the action I need to do to get rid of the New badge (I need to open the chat). For this initial system message I think the chat icon should have a (1) badge already, so users are clicking on it. I also think it would be great to open the chat window on double click of the dispute item as the default action. WDYT? I'm continuing to test the remaining functionality and will add my comments below. But besides that - great improvements already 👍

desktop/src/main/java/bisq/desktop/main/overlays/windows/DisputeSummaryWindow.java

desktop/src/main/java/bisq/desktop/main/shared/ChatView.java

core/src/main/java/bisq/core/support/dispute/Dispute.java

ripcurlx · 2021-03-15T10:47:04Z

I think if multiple chat messages are sent from one dispute which can be resolved by looking at one chat window the badge count on support support should be (1).

ripcurlx · 2021-03-15T10:57:21Z

I'm also not sure if the cog icon is the perfect choice for the process. I always think about settings or preferences when I see it. Maybe CLIPBOARD_CHECK

or FORMAT_LIST_CHECKS could be a better choice. WDYT?

renamed alertCountProperty to badgeCountProperty changed the badge counting policy so that the count of chat messages does not contribute to the badge number, but merely the presence of chat messages, and/or the new flag. show an explanatory message when trader is not allowed to close own dispute ticket removed some comments and code that were accidentally included from PR5160 renamed variable tpe to tradePeriodEnd renamed variable cptyName to counterpartyName clear the new badge on double-click of dispute tablerow

ghost · 2021-03-15T22:39:13Z

@ripcurlx Thanks for the detailed review! I've addressed all issues and have an open question with @leo816 and @huey735 about the Process icon.

ad4927a

renamed alertCountProperty to badgeCountProperty
changed the badge counting policy so that the count of chat messages does not contribute to the badge number, but merely the presence of chat messages, and/or the new flag.
show an explanatory message when trader is not allowed to close own dispute ticket
removed some comments and code that were accidentally included from PR5160
renamed variable tpe to tradePeriodEnd
renamed variable cptyName to counterpartyName
clear the new badge on double-click of dispute tablerow

ghost · 2021-03-16T12:45:02Z

👍 @ripcurlx I implemented latest requested changes.
No response from @huey735 or @leo816 about the process icon, & I prefer the cog.

leo816 · 2021-03-16T13:51:33Z

that seems great, sorry I didn't answer earlier, having a lot of conversations at once and missed this. Good Job.

huey735 · 2021-03-16T22:55:59Z

That's amazing work @jmacxx
Regarding the Process icon, I share @ripcurlx 's sentiment. The cog makes me think of Settings. Maybe a gavel makes more semantic sense.

Or if that's strong, maybe a balance?

@ripcurlx suggestions don't seem thematically relevant. But then again I imagine that with time the chosen icon will gain meaning.

ghost · 2021-03-17T00:39:52Z

pazza83 · 2021-03-17T01:06:17Z

great work @jmacxx many thanks

ripcurlx · 2021-03-17T08:38:31Z

Great work @jmacxx 👍

ripcurlx added this to the v1.6.0 milestone Feb 19, 2021

ghost marked this pull request as draft February 20, 2021 19:46

ghost closed this Feb 25, 2021

ghost reopened this Feb 25, 2021

ghost mentioned this pull request Feb 28, 2021

For Cycle 22 bisq-network/compensation#791

Closed

ghost marked this pull request as ready for review March 4, 2021 01:12

color of new badge should be red

35f6ea2

ripcurlx suggested changes Mar 15, 2021

View reviewed changes

double-click opens chat window

ae9e6da

ghost requested a review from ripcurlx March 16, 2021 12:45

process icon use GAVEL

f93f202

ripcurlx approved these changes Mar 17, 2021

View reviewed changes

ripcurlx merged commit 9270398 into bisq-network:master Mar 17, 2021

ghost mentioned this pull request Apr 2, 2021

For Cycle 23 bisq-network/compensation#814

Closed

leo816 mentioned this pull request Apr 8, 2021

Support Team Lead bisq-network/roles#102

Open

ghost deleted the improve_dispute_chat branch May 29, 2022 22:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve chat functionality of mediation/arbitration #5207

Improve chat functionality of mediation/arbitration #5207

ghost commented Feb 19, 2021 •

edited by ghost

Loading

Conza88 commented Feb 19, 2021

ripcurlx commented Feb 19, 2021 •

edited

Loading

ghost commented Mar 4, 2021

ripcurlx commented Mar 11, 2021

ghost commented Mar 11, 2021

Conza88 commented Mar 14, 2021

ripcurlx left a comment

ripcurlx commented Mar 15, 2021

ripcurlx commented Mar 15, 2021

ghost commented Mar 15, 2021

ghost commented Mar 16, 2021

leo816 commented Mar 16, 2021

huey735 commented Mar 16, 2021 •

edited

Loading

ghost commented Mar 17, 2021

pazza83 commented Mar 17, 2021

ripcurlx commented Mar 17, 2021

Improve chat functionality of mediation/arbitration #5207

Improve chat functionality of mediation/arbitration #5207

Conversation

ghost commented Feb 19, 2021 • edited by ghost Loading

Conza88 commented Feb 19, 2021

ripcurlx commented Feb 19, 2021 • edited Loading

ghost commented Mar 4, 2021

ripcurlx commented Mar 11, 2021

ghost commented Mar 11, 2021

Conza88 commented Mar 14, 2021

ripcurlx left a comment

Choose a reason for hiding this comment

ripcurlx commented Mar 15, 2021

ripcurlx commented Mar 15, 2021

ghost commented Mar 15, 2021

ghost commented Mar 16, 2021

leo816 commented Mar 16, 2021

huey735 commented Mar 16, 2021 • edited Loading

ghost commented Mar 17, 2021

pazza83 commented Mar 17, 2021

ripcurlx commented Mar 17, 2021

ghost commented Feb 19, 2021 •

edited by ghost

Loading

ripcurlx commented Feb 19, 2021 •

edited

Loading

huey735 commented Mar 16, 2021 •

edited

Loading