Improve mediation tools / logging. #5206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emergency payout tool to also show Open mediation tickets. Log txHex of MediatedPayoutTxPublished.
|
It works great. This may be out of the scope of this PR but the fields in the tool disappear into the window's background color. Having a bottom border of the same color as the text should help in making it visible.
|
ghost
mentioned this pull request
|
@huey735 re: text fields disappearing into the popup's background color => made a fix to
|
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were requested by @huey735 & @jmacxx after spending hours debugging #5193.
e.g. (Open mediation tickets)
logging. The recipient of the dispute payout tx should log the txHex they received, it really helps debugging efforts to know what is going on. Otherwise we have no clue without seeing the counter-party's log that does have txHex. The reason for wanting this as opposed to a pretty-print of the transaction, is we can put it into a transaction validator and have it tell us what is wrong e.g. "Signature must be zero for failed CHECK(MULTI)SIG operation".