Fix NPE in trader chat #5175
Merged
Fix NPE in trader chat #5175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show error message to user when trader chat message cannot be sent.
ripcurlx
approved these changes
Feb 12, 2021
ghost
mentioned this pull request
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5132
Fixes #3437
When the trade contract is not set (due to connectivity issues, or erroneous conditions detected by the trade protocol), trader chat is not possible because the information about the peer is not available (it is stored in the contract). This was causing a null pointer exception, instead we should guard against use of the null contract, and show an appropriate error message when a chat message cannot be sent.
Screenshot:
Instead of NPE, this error message:
Testing:
"Trade contract not set" can be reproduced by taking an offer when there is a price discrepancy between Maker and Taker. An example is described in #5102.