New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE at offer entry when trading account switched #5172

Merged

sqrrm merged 1 commit into bisq-network:master from unknown repository

Feb 10, 2021

ghost commented Feb 8, 2021

Fixes #5166

To reproduce the original error:

You have two or more SEPA accounts.
Fill in fields for a new offer using SEPA -> e.g. Buy 0.01 EUR/BTC at 1% above market price.
Enter a value in the field "Deactivate offer if market price is above" value.
Switch the trading account to the other SEPA account.
NPE.


          fix NPE when payment account changed on offer entry (with trigger price)

98feab3

sqrrm approved these changes

View reviewed changes

Member

sqrrm left a comment

ACK

sqrrm merged commit e9e596e into bisq-network:master

ripcurlx added this to the v1.6.0 milestone

sqrrm mentioned this pull request

For Cycle 22 bisq-network/compensation#788

Closed

ghost mentioned this pull request

For Cycle 22 bisq-network/compensation#791

Closed

ghost deleted the fix_npe_offer_trigger_price branch

May 29, 2022 22:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet