Add coin input control #5142
Add coin input control #5142
Conversation
core/src/main/java/bisq/core/btc/wallet/NonBsqCoinSelector.java
Outdated
Show resolved
Hide resolved
core/src/main/java/bisq/core/btc/wallet/BisqDefaultCoinSelector.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/main/dao/wallet/send/BsqSendView.java
Outdated
Show resolved
Hide resolved
| // If we had some selection stored we need to update to already spent entries | ||
| bsqUtxoCandidates = bsqUtxoCandidates.stream(). | ||
| filter(e -> unspentTransactionOutputs.contains(e)). | ||
| collect(Collectors.toSet()); |
There was a problem hiding this comment.
This would remove transactions that are no longer spendable BSQ outputs from the selected outputs. I think that could be confusing. Better to check if the bsqUtxoCandidates are still all spendable, if they are then all is good, if not, then reset the selection to allow choosing between all unspentTransactionOutputs again.
There was a problem hiding this comment.
To request the spendable via bsqWalletService.getSpendableBsqTransactionOutputs() and then check if the bsqUtxoCandidate is in that set does check if the bsqUtxoCandidate is spendable. We use the coinSelector for that and there is no API for checking one utxo if it is still spendable.
Or do I misunderstand what you mean?
| btcUtxoCandidates = btcUtxoCandidates.stream(). | ||
| filter(e -> unspentTransactionOutputs.contains(e)). | ||
| collect(Collectors.toSet()); |
There was a problem hiding this comment.
Same comment as for the BSQ, could be confusing if the selection changes without the users knowing about it
There was a problem hiding this comment.
If you make a send tx and spend a previous selected utxo we need to remove that. We always show that spendable utxos and those are marked the user has selected. A previous selected which got spent need to be removed.
chimp1984
force-pushed
the
add-coin-input-control
branch
from
2fad9aa
to
b37dc15
Compare
There was a bug with the button handlers. Fixed in b37dc15 |
We use that to use only the selected utxos instead of all available.
…onOutputs methods. Add overridden getPreparedSendBsqTx and getPreparedSendBtcTx methods with utxoCandidates param. If utxoCandidates is not null we apply it to our coinSelector. As the coin selector is re-used we re-set it immediately after it was applied (inside coin selector select method). Set preferences in nonBsqCoinSelector
It is both for BSQ and non-BSQ (BTC) used.
chimp1984
force-pushed
the
add-coin-input-control
branch
from
b37dc15
to
9ae76b6
Compare
|
Would be great to reset the validation of the input fields similar as it was before, so it doesn't look like an error after coming back from the success popup.
|
If text field is empty we apply ValidationResult(true), otherwise we apply the validate result with the text and the given validator.
ghost
mentioned this pull request
Adds input selection for BSQ send transactions. We use a utxo based model in contrast to the address based model in the Funds screen. If any dev wants to apply that to the funds screen as well would be good. Also it is better IMO to hide it in a popup as it is a bit technical and might confuse some users.