Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.5.5] Prevent overlapping in offer book tools bar #5133

Merged
merged 3 commits into from
Feb 1, 2021
Merged

[v1.5.5] Prevent overlapping in offer book tools bar #5133

merged 3 commits into from
Feb 1, 2021

Conversation

ripcurlx
Copy link
Contributor

@ripcurlx ripcurlx commented Jan 30, 2021 •
edited
Loading

I've adjusted the layout to prevent hidding of information in our minimum resolution.

Before
Bildschirmfoto 2021-01-30 um 16 36 14

After
Bildschirmfoto 2021-01-30 um 16 49 01

@ripcurlx
Prevent overlapping of offer tools
2839b7a 
Moves everything into box to prevent hiding of information in all languages
@ripcurlx
Cleanup code
4164c77
@ripcurlx ripcurlx added this to the v1.5.5 milestone Jan 30, 2021
@ripcurlx ripcurlx requested a review from sqrrm January 30, 2021 15:59
@ripcurlx ripcurlx changed the title Prevent overlapping in offer book tools bar [v1.5.5] Prevent overlapping in offer book tools bar Jan 30, 2021
ghost
ghost previously approved these changes Feb 1, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, ACK 👍

Minor nit: create offer button alignment looks a bit off, but not a big issue.

@ripcurlx
Copy link
Contributor Author

ripcurlx commented Feb 1, 2021

Tested, ACK 👍

Minor nit: create offer button alignment looks a bit off, but not a big issue.

Ah - true this is as it is now center - aligned by default in this HBox. I'll push a fix for it.

@ripcurlx
Copy link
Contributor Author

ripcurlx commented Feb 1, 2021

@jmacxx The alignment should be now similar to what it was before.
Bildschirmfoto 2021-02-01 um 09 29 56

sqrrm
sqrrm approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sqrrm sqrrm merged commit a819e9e into bisq-network:master Feb 1, 2021
@sqrrm sqrrm mentioned this pull request Feb 27, 2021
Closed
@ripcurlx ripcurlx deleted the fix-ui-overlap-for-offer-matching-feature branch July 16, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sqrrm sqrrm sqrrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.5
Development

Successfully merging this pull request may close these issues.
2 participants
@ripcurlx @sqrrm