[WIP] Add atomic offerpayload #5127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is preparatory work for no fee tx offers. There should be no behavioral changes with this commit. Split OfferPayload into abstract OfferPayload and FeeTxOfferPayload with implementation. Instance variables need to reside in FeeTxOfferPayload in the same order as previously to keep the generated json contract format. Contract is still using FeeTxOfferPayload as I don't think Contract will be used with any other OfferPayload type. Only FeeTxOfferPayload will have the ability to update capabilities. It seems better to just delete the old offer and create a new one if there is no loss in doing so, which there won't be without the fee tx.
More fields might be needed for AtomicOfferPayload. Proof of work for offer broadcast and refresh TTL should probably be handled in StoragePayload or some other wrapper as it would be useful for most messages. Offer protobuf has oneof FeeTxOfferPayload and AtomicOfferPayload. Old clients will be able to handle FeeTxOfferPayloads as they have index 1 but won't be able to parse Offers with any other payload. This is acceptable as they can still trade with old style payloads but fail to parse the new ones and log an error instead. Log is however a bit ugly.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant. |
|
Replaced by #5729 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #5121
Add AtomicOfferPayload
More fields might be needed for AtomicOfferPayload. Proof of work for
offer broadcast and refresh TTL should probably be handled in
StoragePayload or some other wrapper as it would be useful for most
messages.
Offer protobuf has oneof FeeTxOfferPayload and AtomicOfferPayload. Old
clients will be able to handle FeeTxOfferPayloads as they have index 1
but won't be able to parse Offers with any other payload. This is
acceptable as they can still trade with old style payloads but fail to
parse the new ones and log an error instead. Log is however a bit ugly.