Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add four SEPA Payment Account countries: AD, SM, VA, JE. #5123

Merged
merged 1 commit into from Feb 12, 2021
Merged

Add four SEPA Payment Account countries: AD, SM, VA, JE. #5123

merged 1 commit into from Feb 12, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 28, 2021

Fixes bisq-network/growth#209

Add 4 missing SEPA countries: AD, SM, VA, JE.
Performed basic account creation & trading tests on SEPA & SEPA Instant.

Note that previously existing accounts are immutable. If a user wanted to accept trades from one of these countries they would have to create a new account.

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Offers with new restrictions cannot be taken by old clients if only one of the new countries is accepted and new country codes are also displayed in offer details of old clients.

Bildschirmfoto 2021-02-12 um 11 19 37
Bildschirmfoto 2021-02-12 um 11 19 25

@ripcurlx ripcurlx merged commit 8bcd32f into bisq-network:master Feb 12, 2021
@ripcurlx ripcurlx added this to the v1.6.0 milestone Feb 12, 2021
@ghost ghost mentioned this pull request Feb 28, 2021
@ghost ghost deleted the add_sepa_countries branch May 29, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing 4 countries to the SEPA and SEPA Instant payment accounts in Bisq client
1 participant