Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Cash by Mail" instructions improvements #5110

Merged
merged 4 commits into from
Jan 24, 2021

Conversation

Jakub-CZ
Copy link
Contributor

@Jakub-CZ Jakub-CZ commented Jan 23, 2021

1) Fix spaces in "Cash by Mail"

In the English string portfolio.pending.step2_buyer.cashByMail a space is missing after the 2nd sentence.

Screenshot in Transifex:

image

2) Clarify the process of mediation

@pazza83's suggestion from #5092 (comment)

image

@ghost
Copy link

ghost commented Jan 23, 2021

Hopefully when the revised trading rules text is ready, @Jakub-CZ will include it in this PR.
Relevant discussion of the proposed change: #5092 (comment) and onward.

@Jakub-CZ
Copy link
Contributor Author

As suggested by @jmacxx, I've implemented @pazza83's suggestion from #5092 (after the PR got merged).

Additional changes:

  • fixed wording of "... could lead to lose both trading and deposit funds" (in the 5th bullet point in the second list; please somebody review);
  • made the popup wider for fewer line breaks;
  • bumped up the hardcoded character limit to avoid ellipsis in this long block of text.

image

@Jakub-CZ Jakub-CZ changed the title Fix spaces in "Cash by Mail" "Cash by Mail" instructions improvements Jan 23, 2021
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 9005808 into bisq-network:master Jan 24, 2021
@Jakub-CZ Jakub-CZ deleted the fix-spaces-in-cashByMail branch January 24, 2021 16:43
@ripcurlx ripcurlx added this to the v1.6.0 milestone Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants