Define gRPC api call rate constraints #5103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The general rule is limit calls that change p2p data to 1/minute, others to 1/second. An exception is made to set/remove wallet password methods (1/5s), due to the latency of writing wallet changes to disk. This change may affect api testing in the future. If that happens, further changes to the call rate metering interceptor may be made to loosen the constraints when running in regtest/dev mode.
14 tasks
dmos62
reviewed
Jan 25, 2021
| // Trying to set or remove a wallet password several times before the 1st attempt has time to | ||
| // persist the change to disk may corrupt the wallet, so allow only 1 attempt per 5 seconds. | ||
| put("setWalletPassword", new GrpcCallRateMeter(1, SECONDS, 5)); | ||
| put("removeWalletPassword", new GrpcCallRateMeter(1, SECONDS, 5)); |
There was a problem hiding this comment.
This seems like a race condition that can have severe consequences (wallet corruption). Maybe further reduce the rate to be on the safe side?
There was a problem hiding this comment.
Maybe. I was advised to set it to 1/sec, but bumped it to 5/sec for the reason you give here. Let's see what others have to say after they take a look at this.
Move this into a static CallRateMeteringInterceptor.valueOf(Map) method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The general rule is limit calls that change p2p data to 1/minute, others to 1/second. An exception is made to set/remove wallet password methods (1/5s), due to the latency of writing wallet changes to disk.
This change may affect api testing in the future. If that happens, further changes to the call rate metering interceptor may be made to loosen the constraints when running in regtest/dev mode.