Show a confirmation of successfully sending BTC or BSQ from wallet #5071
Conversation
|
Nice!! Not related to this PR but it would be cool to have 2 links to the block explorer, one for clearnet and one for Tor |
|
Thanks for doing this so quickly. Would also be good if mining fees where displayed. |
|
Mining fees are displayed on the "Confirm withdrawal request" popup immediately prior. There's no need to display them after sending. |
The confirmation details include amount, recipient address and txId. Includes a link to open txId details in the user's external block explorer. @m52go reworded the BSQ conf explanation note. Added "don't show again" checkbox.
|
Added "Don't show again" checkbox.
|
| protected void addContent() { | ||
| GridPane.setColumnSpan( | ||
| addMultilineLabel(gridPane, ++rowIndex, note, 0), 2); | ||
| gridPane.add(new Label(""), 0, ++rowIndex); // spacer |
There was a problem hiding this comment.
I normally use for this cases Region which is more lightweight as Label
e.g.
| gridPane.add(new Label(""), 0, ++rowIndex); // spacer | |
| Region spacer = new Region(); | |
| spacer.setMinHeight(20); | |
| gridPane.add(spacer, 0, ++rowIndex); |
Would have the same visual appearance.
| @@ -373,6 +375,12 @@ private void showPublishTxPopup(Coin receiverAmount, | |||
| @Override | |||
| public void onSuccess(Transaction transaction) { | |||
| log.debug("Successfully sent tx with id {}", txWithBtcFee.getTxId().toString()); | |||
| String key = "showTransactionSentBsq"; | |||
There was a problem hiding this comment.
It would be great to get rid of the error message on the empty fields after the successful transfer as well.
For the BsqSendView this would mean changing in the showPublishTxPopup resultHandler into
() -> {
receiversAddressInputTextField.setValidator(null);
receiversAddressInputTextField.setText("");
receiversAddressInputTextField.setValidator(bsqAddressValidator);
amountInputTextField.setValidator(null);
amountInputTextField.setText("");
amountInputTextField.setValidator(bsqValidator);
});
There was a problem hiding this comment.
Not beautiful, but it works 😉
There was a problem hiding this comment.
Thanks @ripcurlx, implemented your suggestions. 👍
Disable validation errors when clearing edit fields Implement spacer field using Region
ghost
mentioned this pull request
ghost
deleted the
As requested, this shows a message of successful sending.
The confirmation details include amount, recipient address and txId.
Includes a link to open txId details in the user's external block explorer.
To be consistent it does the same for both BSQ and BTC.
Fixes #5067
Screenshots:
Note the technicality with sending BSQ is you cannot look up the details in a BSQ explorer until +1 bitcoin confs have passed.
@m52go any thoughts on improving the note text shown in the above popup?
https://github.com/jmacxx/bisq/blob/8f24f0ab9c6d12143c09ecd1bb3bcbaa082bb3e4/core/src/main/resources/i18n/displayStrings.properties#L2699