Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add csv export to bsq tx view #5054

Merged
merged 3 commits into from
Jan 11, 2021

Conversation

chimp1984
Copy link
Contributor

No description provided.

@pazza83
Copy link

pazza83 commented Jan 5, 2021

Hi @chimp1984

Thanks for this it is a good addition.

I was meaning to add a request to include a 'copy' button on this screen DAO > BSQ Wallet > Transactions

It would be good to include a 'copy' button on the columns:

Transaction ID
Information

Lots of times i end up having to open the link and then copying from there. would be good if users could just copy the above in the app.

@ripcurlx
Copy link
Contributor

ripcurlx commented Jan 7, 2021

@chimp1984 Could you please remove the unused reportColumns variable https://app.codacy.com/gh/bisq-network/bisq/pullRequest?prid=6748977 Thanks!

ripcurlx
ripcurlx previously approved these changes Jan 7, 2021
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK except the little change request by Codacy

@ripcurlx ripcurlx added this to the v1.5.5 milestone Jan 7, 2021
@chimp1984
Copy link
Contributor Author

utACK except the little change request by Codacy

Done.

@pazza83
Copy link

pazza83 commented Jan 10, 2021

@chimp1984

Does this is include the request add a request to include a 'copy' button on this screen DAO > BSQ Wallet > Transactions?

If not happy to make a new Git Hub issue for it.

It is only a small change but would be helpful.

@chimp1984
Copy link
Contributor Author

@chimp1984

Does this is include the request add a request to include a 'copy' button on this screen DAO > BSQ Wallet > Transactions?

If not happy to make a new Git Hub issue for it.

It is only a small change but would be helpful.

No thats not included. Maybe you can make a issue with checkboxes of all the open suggestions. So we have that all in one place.

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants