Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.5.4] Check for duplicate hashes at onBundleOfEnvelopes #5032

Merged
merged 3 commits into from
Dec 31, 2020
Merged

[1.5.4] Check for duplicate hashes at onBundleOfEnvelopes #5032

merged 3 commits into from
Dec 31, 2020

Conversation

chimp1984
Copy link
Contributor

Check for duplicate hashes at onBundleOfEnvelopes.
Set log level to debug to not spam logs with it.

@ripcurlx ripcurlx added this to the v1.5.4 milestone Dec 31, 2020
@chimp1984
Copy link
Contributor Author

Travis does not do well toady....

Execution failed for task ':pricenode:compileJava'.

> Could not resolve all files for configuration ':pricenode:compileClasspath'.

   > Could not download xchange-coinmarketcap.jar (org.knowm.xchange:xchange-coinmarketcap:4.4.2)

      > Could not get resource 'https://repo.maven.apache.org/maven2/org/knowm/xchange/xchange-coinmarketcap/4.4.2/xchange-coinmarketcap-4.4.2.jar'.

         > Could not GET 'https://repo.maven.apache.org/maven2/org/knowm/xchange/xchange-coinmarketcap/4.4.2/xchange-coinmarketcap-4.4.2.jar'.

            > Connection reset

sqrrm
sqrrm approved these changes Dec 31, 2020
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sqrrm sqrrm merged commit d633d13 into bisq-network:master Dec 31, 2020
@chimp1984 chimp1984 deleted the check-for-duplicates-at-onBundleOfEnvelopes branch December 31, 2020 15:42
@chimp1984 chimp1984 mentioned this pull request Jan 27, 2021
Closed
@chimp1984 chimp1984 mentioned this pull request Feb 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sqrrm sqrrm sqrrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@chimp1984 @sqrrm @ripcurlx