Tidy up apitest #5024
Merged
Tidy up apitest #5024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't mix junit and jupter apis, apitest should only be using jupiter. Also moved a file.deleteOnExit statement within the method that created the file.
And change log.info to log.debug.
Commit 2070e76 fixed the repeating dao sync bug, so don't need to wait as long after generating a btc block.
sqrrm
approved these changes
Jan 1, 2021
| // We cannot (?) predict the exact tx size and calculate how much in tx fees were | ||
| // deducted from the 5.5 BTC sent to Bob, but we do know Bob should have something | ||
| // between 15.49978000 and 15.49978100 BTC. | ||
| // The sendbtc tx weight and size randomly varies between two distinct values |
There was a problem hiding this comment.
I assume this is a 1 byte difference in address length that is allowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change contains several small bug fixes and refactorings.