Adjust lombok annotations to reduce build warnings #5021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the underlying problems behind five compiler warnings: "Generating equals/hashCode implementation but without a call to superclass". Some core classes use @value and @DaTa annotations where not necessary, for example, where equals, hashCode, and toString are implemented by the developer, and where final class and field modifiers are defined by the developer. From lombok classes and documents for the shortcut annotations @value https://projectlombok.org/features/Value and @DaTa https://projectlombok.org/features/Data, we find some implicit annotations applied by these shortcuts are not needed. Adjustments are described below. - Tx Replace @value with @Getter. - TxOutput Replace @DaTa with @Getter and @Setter. - ChangeParamProposal Replace @value with @Getter. - GetInventoryRequest, GetInventoryResponse An @EqualsAndHashCode(callSuper = false) is added to supress build warnings.
sqrrm
reviewed
Jan 1, 2021
There was a problem hiding this comment.
Makes me nervous changing this magic annotations in the DAO module. It compiles nicely and seems to work fine.
This is the typical case where @ManfredKarrer has to review to make sure this is not breaking some hashes we rely on in the DAO.
chimp1984
suggested changes
Jan 2, 2021
core/src/main/java/bisq/core/dao/state/model/blockchain/TxOutput.java
Outdated
Show resolved
Hide resolved
core/src/main/java/bisq/core/network/p2p/inventory/messages/GetInventoryRequest.java
Outdated
Show resolved
Hide resolved
core/src/main/java/bisq/core/network/p2p/inventory/messages/GetInventoryResponse.java
Outdated
Show resolved
Hide resolved
chimp1984
reviewed
Jan 3, 2021
core/src/main/java/bisq/core/network/p2p/inventory/messages/GetInventoryRequest.java
Outdated
Show resolved
Hide resolved
core/src/main/java/bisq/core/network/p2p/inventory/messages/GetInventoryResponse.java
Outdated
Show resolved
Hide resolved
core/src/main/java/bisq/core/network/p2p/inventory/messages/GetInventoryRequest.java
Outdated
Show resolved
Hide resolved
sqrrm
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the underlying problems behind five compiler warnings:
Generating equals/hashCode implementation but without a call to superclass.Some core classes use
@Valueand@Dataannotations where not necessary, for example, whereequals,hashCode, andtoStringmethods, andfinalclass and field modifiers are defined by a developer.From lombok classes and documents for the shortcut annotations
@Valueand@Data, we find some implicit annotations applied by these shortcuts are not needed. Adjustments are described below.TxReplace@Valuewith@Getter.TxOutputReplace@Datawith@Getterand@Setter.ChangeParamProposalReplace@Valuewith@Getter.GetInventoryRequest,GetInventoryResponseAn@EqualsAndHashCode(callSuper = false)is added to supress build warnings.