Change trade period for transferwise from 1 day to 4 days #5016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pazza83 Could you please ACK this as payment method maintainer? Thanks! |
|
Does make sense. Can be up to 4. |
|
ACK |
ripcurlx
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a bank transfer it takes longer than 1 day. 1 day works only for local TW to local TW account if the sender has already funds on their account.
The trade period is part of the offer, so all offers created with 1.5.2 or earlier will have still 1 day. Users don't need to change anything, the old account will use 4 days for any new offer.