Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing apostrophe in Withdrawal view #5015

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

Jakub-CZ
Copy link
Contributor

@Jakub-CZ Jakub-CZ commented Dec 28, 2020

In FUNDS > SEND FUNDS, labels "Sender's amount"/"Receiver's amount" are missing an apostrophe.

The single quote characters are present in the property file but they get eaten up even though there is no variable substitution taking place (at least it shouldn't be). In the code, however, variable values are provided for no reason.

Before:

Send funds BEFORE

After:

Send funds AFTER

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - good Find!

@ripcurlx ripcurlx merged commit 30cfe5d into bisq-network:master Dec 29, 2020
@ripcurlx ripcurlx added this to the v1.5.3 milestone Dec 29, 2020
@Jakub-CZ Jakub-CZ deleted the fix-withdrawal-label branch December 29, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants