Remove awt dependencies #5008
Merged
Remove awt dependencies #5008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
ghost
marked this pull request as ready for review
|
Could someone with MacOS check that the retina display is detected and the high res Bisq Icon is chosen as a result. Also that links open up the browser correctly. I did testing on Linux and Windows. |
ripcurlx
previously approved these changes
Jan 7, 2021
|
Please resolve the conflict and it is good to get merged. |
|
Merge conflict resolved. Thanks for checking it on MacOS! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4940
Replace usage of awt classes wherever possible with the JavaFX equivalents.
java.awt.Desktopfor opening URIs. UseopenSystemSpecific()instead.java.awt.GraphicsEnvironment. Usejavafx.stage.Screeninstead.Screen.getPrimary().getOutputScaleX() > 1.5;To open a URI we take a convoluted path from
GUIUtil.openWebPage(desktop) toUtilities.openURI(common) toDesktopUtil.browse(common). What do you think about simplifying this by moving DesktopUtil from common to desktop?