Deactivate open offer if trigger price is reached #5001
Conversation
…e-open-offer-if-trigger-price-is-reached
Use only one icon which is set on demand. We will add a new icon later so that refactoring prepares that...
Remove disableProperty().unbind() calls which have never got a bind call before Cleanups
There was a problem hiding this comment.
I do see the offer disabling trigger price in the edit offer view, [EDIT] and can edit it.
But I can't see the disabling trigger price in the published offer views (below). Squeezing it into the list view might not be feasible, but adding it to the other two might be trivial.
Confirm Offer View..
Published Offer List View...
Published Offer Detail View...
| @@ -0,0 +1,151 @@ | |||
| /* | |||
There was a problem hiding this comment.
I instinctively need to ask if PriceUtil could be moved to core. I see dependencies on ChatView.log and ui validators, but much of the util logic could be made available to the api.
There was a problem hiding this comment.
Yes I was thinking the same... was just to lazy to separate pure domain code with formatting stuff which is using desktop scope classes... But yes we should refactor that.
|
I was in the process to add a field there but as it only gets the offer passed but not the openOffer I was not sure... But probably its better to add it as well. There is a trigger price column in openOffersView but it is hidden at default stage width as there is not enough space. If you scale larger it will get added. Similar we use in closed trades, there are a few detail columns only shown when width is larger. I am aware that many users might miss those hidden features, but have not found a good solution yet for it... |
|
Also note that I changed/fixed the above/below term in the price field description. Before it was only changing for BUY/SELL but not for fiat/altcoin. But as fiat price and altcoin price have inverted logic I applied that there as well. |
|
It's good that I can edit the trigger price... |
|
|
Yes was also wondering if that might be good... Not sure also if we should show a popup once a offer gets deactivated. In th list view the shild icon gets yellow in that case. If price is still outside of permitted range the offer also cannot be re-activated directly (would trigger deactivation at next price update) but the user need to edit the offer... Not 100% sure if that is clear to users... Also we do support that feature only for % based price, if you use fixed price you cannot set it as well if there is no price feed like BSQ. Wondering if it would make sense to allow it for those as well?
Haha... I don't care much about xmas and holidays... |
|
If offer got deactivated user need to edit offer and see the validation error: |
We need time off just like religious people ;-)
Not having one is OK for me.
Yes, but maybe put that in another PR? |
Ah, I see. Didn't know what that icon meant but the tooltip explains. Good, better that taking up more real-estate with a 'Trigger Price' column header. I think it's fine the way it is. |
chimp1984
deleted the
deactivate-open-offer-if-trigger-price-is-reached
branch
Implements #4998
Based on #4993