Sign single account #4957
Sign single account #4957
Conversation
Use ctrl+c to copy accountagewitness and pubkey to clipboard in a format to be used by arbitrator to sign the account
Change the specific sign window to sign an imported account in the form of accountAgeWitnessString,pubKeyString. The SignSpecificWitness never worked due to missing pubKey data and this is a way to import the missing data.
core/src/main/java/bisq/core/account/witness/AccountAgeWitnessService.java
Show resolved
Hide resolved
| @@ -62,6 +62,8 @@ public void initialize() { | |||
| accountAgeWitnessService.getAccountAgeWitnessUtils().logSigners(); | |||
| } else if (Utilities.isCtrlShiftPressed(KeyCode.U, event)) { | |||
| accountAgeWitnessService.getAccountAgeWitnessUtils().logUnsignedSignerPubKeys(); | |||
| } else if (Utilities.isAltOrCtrlPressed(KeyCode.C, event)) { | |||
There was a problem hiding this comment.
Cmd+c is a very common key command, not sure if its better to use a more exotic one so that user do not trigger that accidentally. Prob. no harm by doing that, but confusing...
There was a problem hiding this comment.
As its only used for fiat, better move it to fiat class instead of base class
There was a problem hiding this comment.
I like adding it here, and I like ctrl+c since it's the common copy key and that's what we're doing here, copying the account info to clipboard.
There was a problem hiding this comment.
it opens a popup window right?
There was a problem hiding this comment.
or just copy to clipboard?
There was a problem hiding this comment.
sorry have not looked too close to the code base....
There was a problem hiding this comment.
Just copy to clipboard, no need for popup window.
core/src/main/java/bisq/core/account/witness/AccountAgeWitnessService.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/main/overlays/windows/SignSpecificWitnessWindow.java
Show resolved
Hide resolved
core/src/main/java/bisq/core/account/witness/AccountAgeWitnessService.java
Show resolved
Hide resolved
This a proposed solution to bisq-network/growth#212
The user to get signed copies the account data and sends it over whichever channel, keybase for example. With this change the arbitrator can sign this account.
Step 1, user copies account data (ctrl+c to copy AccountAgeWitness and PubKey to clipboard)
Step 2, arbitrator imports data (under accounts view, open signing tab with ctrl+i, in signing tab, open specific account signing window with ctrl+p)
Step 3, arbitrator signs with their private key (this could be helpful for devs that want to test signed accounts as well)
Step 4, done
I know this is very pretty, but please don't ask me to implement all the UI stuff due to this flash feature.