Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort payment methods by display string not by id. #4956

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Sort payment methods by display string not by id. #4956

merged 1 commit into from
Dec 15, 2020

Conversation

chimp1984
Copy link
Contributor

Apply sorting in drop down boxes.

@chimp1984
Sort payment methods by display string not by id.
5c68ad0 
Apply sorting in drop down boxes.
sqrrm
sqrrm reviewed Dec 15, 2020
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, but why do we want to sort by display string rather than id?

@pazza83
Copy link

pazza83 commented Dec 15, 2020

I am assuming strings are the user generated names for their payment accounts?
This allows for payment methods to be sorted by alphabetical order. This would be a great change.

sqrrm
sqrrm approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Thanks @pazza83 for explaining why this is good

@sqrrm sqrrm merged commit f61e62c into bisq-network:master Dec 15, 2020
@chimp1984 chimp1984 deleted the sort-paymentmethods-by-name branch December 15, 2020 23:21
@ripcurlx ripcurlx added this to the v1.5.2 milestone Dec 16, 2020
@chimp1984 chimp1984 mentioned this pull request Dec 26, 2020
Closed
@sqrrm sqrrm mentioned this pull request Dec 28, 2020
Closed
@chimp1984 chimp1984 mentioned this pull request Jan 27, 2021
Closed
@sqrrm sqrrm mentioned this pull request Jan 27, 2021
Closed
@chimp1984 chimp1984 mentioned this pull request Feb 10, 2021
Closed
@sqrrm sqrrm mentioned this pull request Feb 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sqrrm sqrrm sqrrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.2
Development

Successfully merging this pull request may close these issues.
4 participants
@chimp1984 @pazza83 @sqrrm @ripcurlx