Improve offer publishing #4950
Merged
Improve offer publishing #4950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The delay was too long. Some users have 100 - 200 offers and with the 700 ms delay it takes 70-140 sec. This causes more stress for the network and UI due permanent adding of offers. We decreased delay to 30 ms per offer. So with 200 offers it would be about 6 sec. Maybe we could reduce it even further but as it is hard to test in the live network with so many offers it is better to not be too radical with the change.
sqrrm
requested changes
Dec 16, 2020
Invert the if branch so the normal case is first Add comment
Call flush at openOfferManager shutdown. Remove unused method. Force broadcaster to send out immediately, otherwise we could have a 2 sec delay until the bundled messages sent out.
This version is intended to be deployed to a power user to actually try it out live as testing it with real conditions is very difficult.
|
Travis is failing because of broken Tests. |
|
@sqrrm Could you please review the changes so it can be added to the release branch asap? |
sqrrm
reviewed
Dec 17, 2020
The periodicRefreshOffersTimer gets started at offer publishing. Before the stopPeriodicRefreshOffersTimer got overwritten by the start in offer publishing so it did not had any effect beside that we restarted it. Now we process offer publishing without delay and a stop after the call would stop the refresh timer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change handling of delay at republishing
The delay was too long. Some users have 100 - 200
offers and with the 700 ms delay it takes 70-140 sec.
This causes more stress for the network and UI due
permanent adding of offers. We decreased delay to 30 ms per offer.
So with 200 offers it would be about 6 sec. Maybe we could reduce
it even further but as it is hard to test in the live network with
so many offers it is better to not be too radical with the change.