Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sorting of table columns #4923

Merged

Conversation

chimp1984
Copy link
Contributor

Fix incorrect or not optimized sorting of table columns

Include prefix at address column in sort
Use details if available for details column
buyerSecurityDepositColumn, sellerSecurityDepositColumn) if app width get scaled up larger.
Fix sorting of columns.
Fix display of trade fee (BSQ/BTC)
Use num trades for avatar sorting
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 09b253e into bisq-network:master Dec 9, 2020
@ripcurlx ripcurlx added this to the v1.5.2 milestone Dec 9, 2020
@chimp1984 chimp1984 deleted the fix-sorting-of-table-columns branch December 10, 2020 14:31
@pazza83
Copy link

pazza83 commented Jan 3, 2021

This is working really well. Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants