Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update installation script #4893

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Update installation script #4893

merged 1 commit into from
Jan 7, 2021

Conversation

81dr
Copy link
Contributor

@81dr 81dr commented Dec 3, 2020

Resolves case as stated in other PR. Additionally makes some minor corrections.

@boring-cyborg
Copy link

boring-cyborg bot commented Dec 3, 2020

Thanks for opening this pull request!

Please check out our contributor checklist and check if Travis or Codacy found any issues with your PR. Also make sure your commits are signed, and that you applied Bisq's code style and formatting.

A maintainer will add an is:priority label to your PR if it is up for compensation. Please see our Bisq Q1 2020 Update post for more details.

@ripcurlx
Copy link
Contributor

ripcurlx commented Dec 4, 2020

@devinbileck Could you please have a look at this again? Thanks!

@ripcurlx ripcurlx mentioned this pull request Dec 4, 2020
Closed
@ripcurlx
Copy link
Contributor

@devinbileck ☝️ Thanks!

@devinbileck
Copy link
Member

Sorry, I missed this. Will do!

devinbileck
devinbileck approved these changes Dec 31, 2020
View reviewed changes
Copy link
Member

@devinbileck devinbileck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

ripcurlx
ripcurlx approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK based on #4893 (review)

@ripcurlx ripcurlx merged commit 9b2c0e8 into bisq-network:master Jan 7, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 7, 2021

Awesome work, congrats on your first merged pull request!

@ripcurlx ripcurlx added this to the v1.5.5 milestone Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinbileck devinbileck devinbileck approved these changes

@ripcurlx ripcurlx ripcurlx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.5
Development

Successfully merging this pull request may close these issues.
3 participants
@81dr @ripcurlx @devinbileck