Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of Collections to FXCollections in desktop. #4875

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

deusmax
Copy link
Contributor

@deusmax deusmax commented Dec 2, 2020

#\Replace use of java library java.util.Collections with
javafx.collections.FXCollections instead.
Fixes #4388

Replace use of java.util.Collections, except for a few places that use Collections.singleton and Collections.nCopies which do not have direct replacements in FXCollections.
Run code and did not notice any issues.

Replace use of java library java.util.Collections with
javafx.collections.FXCollections instead.
Bisq issue#4388.
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Code changes are looking fine 👍

@ripcurlx ripcurlx merged commit 0d6b17f into bisq-network:master Dec 4, 2020
@ripcurlx ripcurlx added this to the v1.5.2 milestone Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Replace java.util.Collections with FXCollections
2 participants