Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement and test api method 'getunusedbsqaddress' #4798

Merged
merged 8 commits into from
Dec 3, 2020
Merged

Implement and test api method 'getunusedbsqaddress' #4798

merged 8 commits into from
Dec 3, 2020

Commits on Nov 13, 2020

  1. Define new grpc bsq/btc balances protos 

    This change adds proto serivces and messages to support new api
implementations for serving bsq, btc or all wallet balances.

- RPC GetBsqBalances will return complete BSQ balance info.
- Message BsqBalanceInfo is proto returned by rpc GetBsqBalances.

- RPC GetBtcBalances wil return complete BTC balance info.
- Message BtcBalanceInfo is proto returned by rpc GetBtcBalances.

- RPC GetBalances returns complete BTC and BSQ balance info.
- Message BalancesInfo is proto returned by rpc GetBalances.

RPC GetBalance remains unchnaged, still returns only the available
BTC balance.  It may be deprecated and removed in a future PR.
    @ghubstan
    ghubstan committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    fc8af8c View commit details
    Browse the repository at this point in the history

  2. Add proto wrappers for serving bsq, btc or all balances 

    This change adds proto wrappers for sending bsq, btc, or all balances
to the CLI.  They will be used in future api method implementations:
getbsqbalance, getbtcbalance and getbalances.
    @ghubstan
    ghubstan committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    faf45ec View commit details
    Browse the repository at this point in the history

  3. Define proto for api method 'getunusedbsqaddress' 

    This change adds a proto to support a future api implementation for
getting an unused, bsq funding address.
    @ghubstan
    ghubstan committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    4c03b46 View commit details
    Browse the repository at this point in the history

  4. Define proto fapi method 'sendbsq' 

    This change adds the proto to support a future api implementation for
transfering bsq.
    @ghubstan
    ghubstan committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    3e98910 View commit details
    Browse the repository at this point in the history

  5. Add proto fields to support trade fee currency choice 

    This change adds proto support for paying maker fees in bsq or btc.
The implementation will come in a future PR.

- Added makerFeeCurrencyCode field to CreateOfferRequest proto.

- Added isCurrencyForMakerFeeBtc field to OfferInfo proto wrapper.

- Add takerFeeCurrencyCode field to TakeOfferRequest proto.
    @ghubstan
    ghubstan committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    9f033ee View commit details
    Browse the repository at this point in the history

  6. Implement and test api method 'getunusedbsqaddress' 

    - Added new method to CLI, split some long msg strings into two lines,
  and added a white space after a braceless else statement.

- Added the gRPC server boilerplate.

- Added the core implementation.

- Added a test, and moved method wallet tests into their own package.
    @ghubstan
    ghubstan committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    c1c099c View commit details
    Browse the repository at this point in the history

  7. Add teardown to test case

    @ghubstan
    ghubstan committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    7c2068e View commit details
    Browse the repository at this point in the history

  8. Remove trailing spaces in blank line

    @ghubstan
    ghubstan committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    8dc1a74 View commit details
    Browse the repository at this point in the history