Various monitor improvements #4787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename 'Number of responses' to 'Number of requests' Rename timeout err msg @jmacxx: See comment at `getErrorMsgLine`... If you need those historical error msg data in the json as well we need to refactor a bit more...
Reformattings, cleanups
ghubstan
reviewed
Nov 15, 2020
|
utACK |
ripcurlx
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only change which is not only affecting Seed nodes and monitor is the reduction of TTL of mailbox msg from 15 days to 7 days.
This code is used by seed nodes and monitor over the past days/weeks.