Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encrypted wallet password prompt when sending funds from BSQ wallet #4780

Merged
merged 1 commit into from Nov 12, 2020
Merged

Conversation

ghost
Copy link

@ghost ghost commented Nov 11, 2020

When sending BSQ from their Bisq wallet, if password protection is set, users are required to enter their encrypted wallet password.

Corrected wording of transaction confirmation popup to use 'mining fee' instead of 'transaction fee' to make it consistent with wording of the BTC confirmation popup.

Fixes #4719

image

image

Correct wording of transaction confirmation popup to use 'mining fee'
instead of 'transaction fee' to make it consistent with wording of
the BTC confirmation popup.
@ripcurlx ripcurlx added this to the v1.5.1 milestone Nov 11, 2020
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@chimp1984
Copy link
Contributor

Great thanks for picking that up!

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 34c802d into bisq-network:master Nov 12, 2020
@ghost ghost mentioned this pull request Nov 26, 2020
@ghost ghost deleted the fix_issue_4719 branch October 18, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add encrypted wallet password prompt when sending funds from BSQ wallet
2 participants