Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default fee rate from Bisq startup screen #4767

Merged
merged 1 commit into from Nov 9, 2020
Merged

Remove default fee rate from Bisq startup screen #4767

merged 1 commit into from Nov 9, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 8, 2020

The display of fee rate on the startup screen is misleading because at startup a fee has not been received from the mempool fee service and instead the default value of 50 sats is shown.

This change causes the fee rate not to be displayed until a response has been received from the service.

Fixes #4765

Bisq loading screen, fee no longer displayed:
image

Footer of Bisq main screen:
image

The display of fee rate on the startup screen is misleading because
at startup a fee has not been received from the mempool fee service
and instead the default value of 50 sats is shown.

This change causes the fee rate not to be displayed until a response
has been received from the service.

Fixes #4765
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 0345c79 into bisq-network:master Nov 9, 2020
@ghost ghost mentioned this pull request Nov 26, 2020
@ghost ghost deleted the fix_issue_4765 branch May 29, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bisq startup screen shows incorrect mempool fee rate
1 participant