Various improvements in GetBlocks handling #4749
Conversation
chimp1984
force-pushed
the
fix-dao-sync-issues
branch
from
e4e38e0 to
afa3448
Compare
|
Seem Travis has issues. Did a full build/test locally and all was ok. Please ignore codacy warning. |
I removed the pattern. Please force push to re-trigger Codacy. Thanks! |
|
@ripcurlx Force push does not work to re-trigger it from my last experience. You cannot merge when Codacy complains? I thouhgt its non-blocking? Btw. that PR should not get into 1.5.0, too risky to getting added that later. |
It worked for me so far. It is configured as non-blocking, but that GitHub settings seems to be not working correctly. We'll get soon to a state where Codacy only will complain if there is a reason for it 😉 |
|
Merged with master and resolved merge conflicts |
Remove final statements Change log level and log msg
Return early Don't require that connections address must be present Stop timer in case it was not null
Remove first seed we use from seedNodeAddresses Return early
In case we get the handlers called before we have ever made a request lastRequestedBlockHeight is 0 and we would request the max. number of blocks.
is ready we would get an exception in walletConfig.chain())
chimp1984
force-pushed
the
fix-dao-sync-issues
branch
from
f8462fd to
d60a2dd
Compare
No description provided.