Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user-defined block explorers #4733

Merged
merged 1 commit into from Nov 2, 2020
Merged

Allow user-defined block explorers #4733

merged 1 commit into from Nov 2, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 31, 2020

In Settings/General Preferences the Bitcoin Explorer and Bisq Explorer may now be user defined in addition to the hard coded block explorer choices.

This implementation takes advantage of the existing Protobuf implementation that stores a BlockExplorer Name/UrlTx/UrlAddress for BTC and for BSQ.

A new popup dialog is implemented which allows editing of the explorer details (name, txUrl, and addressUrl). Any of the system-defined explorer details may be selected into the edit fields thus allowing them to be used as templates, customized or an entirely new explorer to be used.

If the user switches choice from a customized back to a pre-defined explorer then the customized settings are gone; this is because the Protobuf storage only allows saving one selection.

Fixes #4371
Closes #4634

image

image

@ghost
Copy link
Author

ghost commented Oct 31, 2020

Fixes #4634

@cd2357
Copy link
Contributor

cd2357 commented Oct 31, 2020

ACK, tested and works as expected.

chimp1984
chimp1984 previously approved these changes Nov 1, 2020
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Beside 2 nits... See comments

chimp1984
chimp1984 previously approved these changes Nov 1, 2020
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK

Code looks fine, but please change the style of the >> button to match our general button style.

In Settings/General Preferences the Bitcoin Explorer and Bisq Explorer may
now be user defined in addition to the hard coded block explorer choices.

This implementation takes advantage of the existing Protobuf implementation
that stores a BlockExplorer Name/UrlTx/UrlAddress for BTC and for BSQ.

A new popup dialog is implemented which allows editing of the explorer
details (name, txUrl, and addressUrl).  Any of the system-defined
explorer details may be selected into the edit fields thus allowing
them to be used as templates, customized or an entirely new explorer to
be used.

If the user switches choice from a customized back to a pre-defined
explorer then the customized settings are gone; this is because the
Protobuf storage only allows saving one selection.

Fixes #4371
Closes #4634
@sqrrm
Copy link
Member

sqrrm commented Nov 2, 2020

@ripcurlx Are you ok with this PR now? Will leave merge for you

@ripcurlx ripcurlx merged commit 3d72738 into bisq-network:master Nov 2, 2020
@ripcurlx ripcurlx added this to the v1.5.0 milestone Nov 3, 2020
@cbeams
Copy link
Contributor

cbeams commented Nov 4, 2020

Great to see this functionality, thanks @jmacxx!

One note for potential future contributions: it would be great to be able to have more than one custom explorer. This is from my original description of the feature at #4371 (comment):

While it might be easiest to support adding just one custom block explorer, it would be ideal to allow specifying multiple of them, because in the case of an explorer running on one's local network, one might wish to access it via clearnet http when at home and via Tor when remote. This would require specifying two sets of URLs. And of course the user might want to specify any number of additional custom explorer services.

@ghost ghost mentioned this pull request Nov 26, 2020
@ghost ghost deleted the edit_explorer_details branch May 29, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support setting one or more user-defined block explorers
5 participants