-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user-defined block explorers #4733
Conversation
Fixes #4634 |
ACK, tested and works as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Beside 2 nits... See comments
desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NACK
Code looks fine, but please change the style of the >>
button to match our general button style.
desktop/src/main/java/bisq/desktop/main/overlays/windows/EditCustomExplorerWindow.java
Outdated
Show resolved
Hide resolved
In Settings/General Preferences the Bitcoin Explorer and Bisq Explorer may now be user defined in addition to the hard coded block explorer choices. This implementation takes advantage of the existing Protobuf implementation that stores a BlockExplorer Name/UrlTx/UrlAddress for BTC and for BSQ. A new popup dialog is implemented which allows editing of the explorer details (name, txUrl, and addressUrl). Any of the system-defined explorer details may be selected into the edit fields thus allowing them to be used as templates, customized or an entirely new explorer to be used. If the user switches choice from a customized back to a pre-defined explorer then the customized settings are gone; this is because the Protobuf storage only allows saving one selection. Fixes #4371 Closes #4634
@ripcurlx Are you ok with this PR now? Will leave merge for you |
Great to see this functionality, thanks @jmacxx! One note for potential future contributions: it would be great to be able to have more than one custom explorer. This is from my original description of the feature at #4371 (comment):
|
In Settings/General Preferences the Bitcoin Explorer and Bisq Explorer may now be user defined in addition to the hard coded block explorer choices.
This implementation takes advantage of the existing Protobuf implementation that stores a BlockExplorer Name/UrlTx/UrlAddress for BTC and for BSQ.
A new popup dialog is implemented which allows editing of the explorer details (name, txUrl, and addressUrl). Any of the system-defined explorer details may be selected into the edit fields thus allowing them to be used as templates, customized or an entirely new explorer to be used.
If the user switches choice from a customized back to a pre-defined explorer then the customized settings are gone; this is because the Protobuf storage only allows saving one selection.
Fixes #4371
Closes #4634