Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally print the json contract for a given trade id #4705

Merged
merged 15 commits into from
Oct 30, 2020
Merged

Optionally print the json contract for a given trade id #4705

merged 15 commits into from
Oct 30, 2020

Commits on Oct 23, 2020

  1. Block on tx-fee-request in core TakeOfferModel init 

    Added license comment too.
    @ghubstan
    ghubstan committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    cb65de6 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2020

  1. Add compiler warning suppression, remove comment

    @ghubstan
    ghubstan committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    ab20225 View commit details
    Browse the repository at this point in the history

  2. Add fields to grpc TradeInfo proto & wrapper

    @ghubstan
    ghubstan committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    63cf436 View commit details
    Browse the repository at this point in the history

  3. Replace static TradeUtil with singleton TradeUtil 

    The API is going to need some desktop trade utilities, which should be
shared between :desktop and :core.api.
    @ghubstan
    ghubstan committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    296e4f9 View commit details
    Browse the repository at this point in the history

  4. Fix comment typos

    @ghubstan
    ghubstan committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    ccd3c99 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2020

  1. Refactor PendingTradesViewModel methods -> TradeUtil & OfferUtil

    @ghubstan
    ghubstan committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    24ba921 View commit details
    Browse the repository at this point in the history

  2. Remove trailing spaces for codacy

    @ghubstan
    ghubstan committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    36ad137 View commit details
    Browse the repository at this point in the history

  3. Refactor PendingTradesDataModel methods -> TradeUtil 

    Scope of this refactoring is small;  more can be done, but the short
term goal is to share trade util logic with core api.

- Removed unused method getCurrencyCode()
- Made minor style changes
- Removed duplicated code block
    @ghubstan
    ghubstan committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    95bcb1e View commit details
    Browse the repository at this point in the history

  4. Remove unused import

    @ghubstan
    ghubstan committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    bbd7a31 View commit details
    Browse the repository at this point in the history

  5. Add getRole(tradeId) to core api 

    API users will need to see their role as maker/taker when looking at trade details.

- Add getRole(trade) to TradeUtil.
- Add getTradeRole(tradeId) to CoreApi, CoreTradesService.
- Add role field to TradeInfo proto and its wrapper class.
    @ghubstan
    ghubstan committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    161dbad View commit details
    Browse the repository at this point in the history

  6. Refactor CLI output formatting code & add trade formatter 

    - Move output column header specs to its own shared constants class.

- Add new TradeFormat class for printing trade details in the console.

- Print formatted trade in api trade tests -- to see output before
  using formatter in CLI (in next PR).
    @ghubstan
    ghubstan committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    3379376 View commit details
    Browse the repository at this point in the history

  7. Add license comment

    @ghubstan
    ghubstan committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    d8bc265 View commit details
    Browse the repository at this point in the history

  8. Move semicolon up from blank line

    @ghubstan
    ghubstan committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    31435bb View commit details
    Browse the repository at this point in the history

  9. Add 'gettrade' to api method CLI

    @ghubstan
    ghubstan committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    2b23704 View commit details
    Browse the repository at this point in the history

  10. Add boolean 'showcontract' argument to api's 'gettrade' 

    Optionally print the json contract for a given trade id.
    @ghubstan
    ghubstan committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    a2b2923 View commit details
    Browse the repository at this point in the history