Block on tx-fee-request in core TakeOfferModel init #4692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added license comment too.
This was referenced Oct 23, 2020
sqrrm
approved these changes
Oct 27, 2020
There was a problem hiding this comment.
utACK
@chimp1984 what was the reason for not waiting for the fee here? Seems like it should.
chimp1984
reviewed
Oct 27, 2020
There was a problem hiding this comment.
utACK
@chimp1984 what was the reason for not waiting for the fee here? Seems like it should.
I don't have the full context here, but I prefer to not add blocking code, but deal with asycn calls via callbacks. But if its API only and hard otherwise I am fine...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core api's take offer model needs to wait on async operations during initialization.
Added license comment too.