-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show current tx fee rate on main screen #4676
Conversation
Tx fee rate is shown in the footer alongside "Synchronized with Bitcoin Mainnet (using Tor) (x sat/vB)". Fixes #4412
I think we might need more context for everyone to understand this number. What do you think about changing it to: |
Maybe instead of Fewer characters, less space taken, with same meaning. |
The screenshots are very persuasive :) Your initial version looks the best. |
@jmacxx Consider to only show it at final sync state, so the space issues are not a problem as only at sync it gets long. Another option is to hide the "synchroonized with btc network" after a while or shorten it. The "using Tor" is not needed IMO. |
Suggestion: Left: Right: |
@wiz Could you weigh in with an opinion? |
@chimp1984 There is text added to the footer in the desktop MainViewModel.java which is unknown at the point where the bulk of the synced message is built in WalletAppSetup.java. So not sure how to avoid that. The |
Not sure as well without trying it out myself, but I think we do not need to show all info all the time. So if there is a dao block sync maybe remove some of the other info text. Or shorten it as well. Update messages are displayed there as a well... |
Shorten "synchronized" to "synced" Move Bitcoin network peer count to right with Bisq network peer count Moved "Synchronizing DAO" to center for clarity/balance.
adding the rate as a number is good, but also visualizing it with colors or a progress bar meter thing would be better |
I fear that would overload it. UI is already heavy with information... |
good point, but just something simple like |
Maybe @pedromvpg could add his opinion or make a suggestion? But probably not important enough to waste his precious time... |
I'd prefer to keep it simple and be done with it. Only really wanted (x sat/vB) on display. |
I think it looks great an it would be very helpful. Thinking that adding color would potentially call too much attention to itself. Also, do we need to clarify the fee rate targets 1 block confirmation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Tx fee rate is shown in the footer alongside
Synchronized with Bitcoin Mainnet (using Tor) (x sat/vB)
.Fixes #4412
Screenshot: