-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve bisq setup #4592
Improve bisq setup #4592
Conversation
Codacy does not read comments :-). There is a reason to not make that field local. Please ignore stupid codacy bot. |
Note to @ghubstan : delete |
See comments to classes for reasoning.
c161cdc
to
474c413
Compare
Rebased on master. |
I'm ready to merge this but will wait for #4568 to get merged first. |
I removed the Codacy pattern based on the comment next to the variable. @chimp1984 Please force push to re-trigger Codacy checks. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
After decision to merge segwit changes directly into release branch, this can now be merged.
Provides a new AppStartupState class for listening for combined startup states.
Extract domain startup code to a new class to avoid that BisqSetup gets overloaded.
We often need to wait until network and wallet is ready or other combination of startup states.
To avoid those repeated checks for the state or setting of listeners on different domains we provide here a
collection of useful states.
I did not use listeners as we want to query the state as well, so we needed fields keeping the state. Using a BooleanProperty provides both a field for keeping the state as well as a convenient way to add a listener.
E.g.: