Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add segwit support to the BTC wallet #4568

Merged
merged 30 commits into from
Oct 8, 2020
Merged

Add segwit support to the BTC wallet #4568

merged 30 commits into from
Oct 8, 2020

Commits on Oct 8, 2020

  1. Create a P2WPKH keychain for new btc wallets

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    f13a7b1 View commit details
    Browse the repository at this point in the history

  2. Add a P2WPKH keychain for existing wallets

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    cd28660 View commit details
    Browse the repository at this point in the history

  3. AddressEntry: Add boolean segwit flag

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    ced357c View commit details
    Browse the repository at this point in the history

  4. Stop using LegacyAddress for btc addresses

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    e85c66b View commit details
    Browse the repository at this point in the history

  5. Fix log msg in BtcCoinSelector

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    0c7f345 View commit details
    Browse the repository at this point in the history

  6. Comment out segwit BSQ account path 

    Segwit is not used for BSQ
    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    0f4c66f View commit details
    Browse the repository at this point in the history

  7. TradeWalletService: adapt to segwit wallet

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    2551571 View commit details
    Browse the repository at this point in the history

  8. WalletService: adapt to segwit wallet

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    d8b7557 View commit details
    Browse the repository at this point in the history

  9. New AddressEntry: use different script types 

    Use P2WPKH for AVAILABLE context and P2PKH for the rest.
Disable reusing unused AVAILABLE entries until segwit support is
mandatory in Bisq.
    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    a370848 View commit details
    Browse the repository at this point in the history

  10. AddressEntryList: arbitrator entry use P2PKH

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    a9cc28f View commit details
    Browse the repository at this point in the history

  11. Add segwit/legacy checbox for address creation

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    f9f5d92 View commit details
    Browse the repository at this point in the history

  12. Serialize tx without segwit 

    This is for backwards compatibility with bisq nodes that have not
upgraded to bitcoinj 0.15.
    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    1f3c585 View commit details
    Browse the repository at this point in the history

  13. Don't create an extra address at startup

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    58afc00 View commit details
    Browse the repository at this point in the history

  14. Don't create a wallet address when not needed

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    e2f74f0 View commit details
    Browse the repository at this point in the history

  15. Remove unused WalletService.findKeyFromPubKeyHash()

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    d1aeedd View commit details
    Browse the repository at this point in the history

  16. Remove unused import

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    78a2a43 View commit details
    Browse the repository at this point in the history

  17. Enable reusing unused AVAILABLE entries

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    01455d2 View commit details
    Browse the repository at this point in the history

  18. Make codacy happy

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    4a2c0ad View commit details
    Browse the repository at this point in the history

  19. Validate AddressEntry.segwit

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    86ddd06 View commit details
    Browse the repository at this point in the history

  20. Make it clear segwit is not used for the trade protocol yet.

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    b9e404f View commit details
    Browse the repository at this point in the history

  21. BtcWalletService.getFreshAddressEntry(): code clean up

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    5524ba3 View commit details
    Browse the repository at this point in the history

  22. Construct dummy outputs with LegacyAddress

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    d1aaf3e View commit details
    Browse the repository at this point in the history

  23. setWitness(): Code clean up

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    3554e19 View commit details
    Browse the repository at this point in the history

  24. Use try-with-resources

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    499d7b7 View commit details
    Browse the repository at this point in the history

  25. Improve error handling for P2WPKH

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    1d82c01 View commit details
    Browse the repository at this point in the history

  26. Switch back to LegacyAddress for fee estimation

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    3 Configuration menu
    Copy the full SHA
    694446c View commit details
    Browse the repository at this point in the history

  27. Fix add segwit keychain for encrypted wallet

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    a747e83 View commit details
    Browse the repository at this point in the history

  28. Use bitcoinj 0.15.8 (commit a733034)

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    417daf5 View commit details
    Browse the repository at this point in the history

  29. Do a backup of the wallet before segwit migration

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    87da2ae View commit details
    Browse the repository at this point in the history

  30. Check migratedWalletToSegwit is true

    @oscarguindzberg
    oscarguindzberg committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    261e0ec View commit details
    Browse the repository at this point in the history