Display the calculated security deposit at order entry #4555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4426 Always calculate the suggested security deposit based on asset price volatility rather than using a persisted value as the minimum.
ghost
mentioned this pull request
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always display at order entry screen the calculated security deposit and leave the decision to make it higher or lower to users for every offer. Do not persist the value to user settings, since Bisq now calculates the suggested value each time. (Prior to this a user setting
minimum security depositvalue was being displayed)Fixes #4426
Description of why calculated security deposit did not always display before: #4426 (comment)