Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeouts #4521

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Increase timeouts #4521

merged 1 commit into from
Sep 14, 2020

Conversation

chimp1984
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented Sep 13, 2020

Could we increase DEFAULT_BROADCAST_TIMEOUT? It seems many transactions currently result in an error Broadcast of tx [...] not completed after 5 sec.

@sqrrm
Copy link
Member

sqrrm commented Sep 14, 2020

@jmacxx Looking at the DEFAULT_BROADCAST_TIMEOUT we probably have to do some more work to make it safe to increase

    // Currently there is a bug in BitcoinJ causing the timeout at all BSQ transactions.
    // It is because BitcoinJ does not handle confidence object correctly in case as tx got altered after the
    // Wallet.complete() method is called which is the case for all BSQ txs. We will work on a fix for that but that
    // will take more time. In the meantime we reduce the timeout to 5 seconds to avoid that the trade protocol runs
    // into a timeout when using BSQ for trade fee.
    private static final int DEFAULT_BROADCAST_TIMEOUT = 5;

Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sqrrm sqrrm merged commit 5911667 into bisq-network:master Sep 14, 2020
@ripcurlx ripcurlx added this to the v1.3.8 milestone Sep 14, 2020
@chimp1984
Copy link
Contributor Author

According the logs there are expected timeouts for BSQ txs. We should look into the issue inside BitcoinJ to fix that or even reduce the timeout here, or handle it differently if BSQ or BTC only....

@chimp1984 chimp1984 deleted the increase-timeouts branch September 15, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants