Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show popup about key-logger warning if OSX version is >= 10.14 #4464

Merged

Conversation

chimp1984
Copy link
Contributor

@chimp1984 chimp1984 commented Sep 2, 2020

Tell user about the issue and instruct him how to change OS settings.

Helps to mitigate #3373

@ripcurlx I think 10.14 and above are affected, right?

@m52go Could you review the message?

popup.warning.osxKeyLoggerWarning=Due to stricter security measures in macOS 10.14 and above, launching a JavaFX app \
  (Bisq used JavaFX) causes a popup warning in OSX ('Bisq would like to receive keystrokes from any application').\n\n\
  To avoid that issue please open your 'OSX Settings' and go to 'Security & Privacy' -> 'Privacy' -> \
  'Input Monitoring' and Remove 'Bisq' from the list on the right side.\n\n\
  Bisq will upgrade to a newer Java version to avoid that issue as soon the technical limitations \
  (Java packager for the required Java version is not shipped yet) are resolved.

Tell user about the issue and instruct him how to change OS settings.
@m52go
Copy link
Contributor

m52go commented Sep 2, 2020

Main changes:

  • removed reference to JavaFX (more important to developers...most users probably don't know/understand what it is)
  • changed "OS X" reference to "macOS" since that's the way it's currently branded
popup.warning.osxKeyLoggerWarning=Due to stricter security measures in macOS 10.14 and above, launching Bisq \
  shows a macOS warning pop-up with the message "Bisq would like to receive keystrokes from any application".\n\n\
  To avoid this issue, please open macOS System Preferences and go to "Security & Privacy" > "Privacy" > \
  "Input Monitoring" and remove "Bisq" from the list on the right side.\n\n\
  Bisq will upgrade to a newer Java version to avoid this issue as soon as technical limitations \
  are resolved (the Java packager for the required Java version is not available yet).

@chimp1984
Copy link
Contributor Author

Updated text:

popup.warning.osxKeyLoggerWarning=Due to stricter security measures in macOS 10.14 and above, launching a Java application \
  (Bisq used Java) causes a popup warning in macOS ('Bisq would like to receive keystrokes from any application').\n\n\
  To avoid that issue please open your 'macOS Settings' and go to 'Security & Privacy' -> 'Privacy' -> \
  'Input Monitoring' and Remove 'Bisq' from the list on the right side.\n\n\
  Bisq will upgrade to a newer Java version to avoid that issue as soon the technical limitations \
  (Java packager for the required Java version is not shipped yet) are resolved.

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 3df9428 into bisq-network:master Sep 3, 2020
@chimp1984 chimp1984 deleted the show-popup-for-osx-key-logger-warning branch September 3, 2020 15:07
@ripcurlx ripcurlx added this to the v1.3.8 milestone Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants